fs: support io_uring in fs::metadata (statx) #7616
Closed
+253
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WowVeryLogin
force-pushed
the
denis/statx_metadata_uring
branch
12 times, most recently
from
f1e4ee8 to
91cbf67
Compare
WowVeryLogin
force-pushed
the
denis/statx_metadata_uring
branch
from
91cbf67 to
be596a9
Compare
|
Hi, sorry I missed this PR. I don't think we can implement |
Could you elaborate on this or open an issue by any chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add io-uring version of fs::metadata. The tricky part here is that there is no way to construct std::fs::Metadata from libc::statx outside of std, so had to add ugly hack with shim:
So on completion I call std::fs:metadata to construct std::fs::Metadata type out of intercepted statx syscall.
And also noticed that fs_uring tests are flakky because one of the tests specifically requests too many files interfiring with other tests.